Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove pointless (and wrong) config check #287

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

lynnagara
Copy link
Member

This is just wrong since it doesn't include all options

This is just wrong since it doesn't include all options
@lynnagara lynnagara requested a review from a team as a code owner September 26, 2023 04:49
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
arroyo/backends/kafka/configuration.py 65.78% <50.00%> (-0.88%) ⬇️

📢 Thoughts on this report? Let us know!.

@lynnagara lynnagara merged commit 7f039bb into main Sep 26, 2023
9 of 10 checks passed
@lynnagara lynnagara deleted the remove-broker-config-check branch September 26, 2023 04:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants