Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update query for Elasticsearch 7.x #474

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

inggilove
Copy link

With Elasticsearch 7.x or Open Distro for Elasticsearch 1.x,
Invalid query parameter is updated

With Elasticsearch 7.x or Open Distro for Elasticsearch 1.x,
Invalid query parameter is updated
@susodapop
Copy link
Contributor

Thanks!

@susodapop susodapop self-requested a review August 24, 2020 20:25
@susodapop
Copy link
Contributor

Can you link any documentation about this change? I don't see it mentioned in the breaking changes doc for v7. And we don't have an ES instance to test against.

@inggilove
Copy link
Author

inggilove commented Aug 28, 2020

Thanks for your review.
It was a mistake to the version of 'Elasticsearch 6.0 or older'
Actually the parameter 'fields' is deprecated from Elasticsearch 5.0, so some text have to be changed...

I attached the reference blog:

(1) Change Info ( Elasticsearch v5.0 )
https://www.elastic.co/guide/en/elasticsearch/reference/5.0/breaking_50_search_changes.html#_search_shard_limit

(2) Elasticsearch Sample
Latest v7.x : https://www.elastic.co/guide/en/elasticsearch/reference/7.x/search-fields.html#stored-fields
v5.0 : https://www.elastic.co/guide/en/elasticsearch/reference/5.0/search-request-stored-fields.html

@inggilove
Copy link
Author

Older version changes like 'fields', 'limit' are removed because Elasticsearch 2.x looks too older compared to Elasticsearch 7.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants