BigQuery: add date, datetime type mapping #7252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yoshiokatsuneo
force-pushed
the
bigquery_datetime_date
branch
from
37cb745 to
ef7c986
Compare
yoshiokatsuneo
force-pushed
the
bigquery_datetime_date
branch
from
ef7c986 to
60eaadc
Compare
harveyrendell
pushed a commit
to pushpay/redash
that referenced
this pull request
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
On BigQuery, DATE and DATETIME type are not mapped to specific type, so it sometimes handled as "string" type and shown as number.
This PR add mapping for DATETIME/DATE in addition to TIMESTAMP.
How is this tested?
I just run the query below and confirmed that the column is displayed in date format instead of number.