Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify counter widgets font size in pt #6537

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

eradman
Copy link
Collaborator

@eradman eradman commented Oct 18, 2023

  • prevent scrollbars from appearing
  • start with a base font size of 12pt for more even scaling

What type of PR is this?

  • Other

Description

To solve font scaling isues on HiDPI displays
See #6521

How is this tested?

  • Manually

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

counter-screenshot1

- prevent scrollbars from appearing
- start with a base font size of 12pt for more even scaling
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #6537 (aa1facf) into master (8bb1767) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6537   +/-   ##
=======================================
  Coverage   61.88%   61.88%           
=======================================
  Files         158      158           
  Lines       12965    12965           
  Branches     1770     1770           
=======================================
  Hits         8024     8024           
  Misses       4666     4666           
  Partials      275      275           

Copy link
Contributor

@guidopetri guidopetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Eric :)

@guidopetri guidopetri enabled auto-merge (squash) October 19, 2023 01:42
@guidopetri guidopetri merged commit 593b6ae into getredash:master Oct 19, 2023
13 checks passed
@eradman eradman deleted the counter-viz branch October 19, 2023 12:48
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
- prevent scrollbars from appearing
- start with a base font size of 12pt for more even scaling

Co-authored-by: Guido Petri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants