Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yarn network-timeout: 30s(default) -> 600s #6531

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Update yarn network-timeout: 30s(default) -> 600s #6531

merged 2 commits into from
Oct 17, 2023

Conversation

winebarrel
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

In the docker build of GitHub Actions, yarn failed with ESOCKETTIMEDOUT, so change the network-timeout.

cf. https://github.com/getredash/redash/actions/runs/6533929053/job/17752711820#step:9:2944

#35 1402.3 error An unexpected error occurred: "https://registry.yarnpkg.com/core-js/-/core-js-2.6.12.tgz: ESOCKETTIMEDOUT".

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

N/A

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Merging #6531 (abbbdf1) into master (a2c0c48) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6531   +/-   ##
=======================================
  Coverage   61.53%   61.53%           
=======================================
  Files         158      158           
  Lines       12898    12898           
  Branches     1756     1756           
=======================================
  Hits         7937     7937           
  Misses       4704     4704           
  Partials      257      257           

@justinclift
Copy link
Member

Ahhh, cool. I was thinking we might need to back out the arm64 PR, but if this works instead then it's the better way to go.

@justinclift justinclift enabled auto-merge (squash) October 17, 2023 11:19
@justinclift justinclift merged commit 69d1e03 into getredash:master Oct 17, 2023
13 checks passed
@justinclift
Copy link
Member

justinclift commented Oct 17, 2023

Interestingly, with this value changed the CI docker push job no longer times out immediately. 🥳

Instead, it times out after six hours of building the arm64 image very, very, very slowly: ☹️

image

@justinclift
Copy link
Member

We'd better back out this change, and the arm64 one too, so that preview Docker Hub builds start being reliably created again.

That being said, if there's some way to get the arm64 builds working reliably later on then that'd be welcome. 😄

justinclift added a commit that referenced this pull request Oct 17, 2023
This PR reverts PRs #6525 and #6531, due to problems building
the arm64 images with GitHub Actions
guidopetri pushed a commit that referenced this pull request Oct 18, 2023
This PR reverts PRs #6525 and #6531, due to problems building
the arm64 images with GitHub Actions
@winebarrel winebarrel deleted the set_yarn_network-timeout branch October 18, 2023 01:01
@winebarrel
Copy link
Contributor Author

@justinclift Sorry for breaking the test..

Thanks for undoing the changes.

@justinclift
Copy link
Member

It's no worries. It was worth trying out the PR just in case it all worked. 😄

Don't be afraid to experiment and try things out. 😁

harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
harveyrendell pushed a commit to pushpay/redash that referenced this pull request Jan 8, 2025
This PR reverts PRs getredash#6525 and getredash#6531, due to problems building
the arm64 images with GitHub Actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants