Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused parameters from ActionArguments struct #3333

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove unused parameters from ActionArguments struct #3333

wants to merge 1 commit into from

Conversation

kichristensen
Copy link
Contributor

@kichristensen kichristensen commented Feb 11, 2025 •
edited
Loading

What does this change

Remove unused parameters from ActionArguments struct.

What issue does it fix

related to #2699

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

@kichristensen kichristensen changed the title WIP: Just-in-time paramater resolve WIP: Just-in-time parameter resolve Feb 13, 2025
@kichristensen
TEMP
73fd4e6 
Signed-off-by: Kim Christensen <[email protected]>
@kichristensen kichristensen changed the title WIP: Just-in-time parameter resolve Remove unused parameters from ActionArguments struct Feb 13, 2025
@kichristensen kichristensen marked this pull request as ready for review February 13, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schristoff schristoff Awaiting requested review from schristoff schristoff is a code owner

@sgettys sgettys Awaiting requested review from sgettys sgettys is a code owner

@bdegeeter bdegeeter Awaiting requested review from bdegeeter bdegeeter is a code owner

@troy0820 troy0820 Awaiting requested review from troy0820 troy0820 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kichristensen