-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mapped dependency outputs #3058
Merged
schristoff
merged 8 commits into
getporter:main
from
kichristensen:mappedDependencyOutputs
May 15, 2024
Merged
Add support for mapped dependency outputs #3058
schristoff
merged 8 commits into
getporter:main
from
kichristensen:mappedDependencyOutputs
May 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kim Christensen <[email protected]>
schristoff
requested changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate you taking action on this :)
Signed-off-by: Kim Christensen <[email protected]>
Signed-off-by: Kim Christensen <[email protected]>
schristoff
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change
Implements support for dependency output mapping in Dependencies V2.
This is precursor to #2662 as it requires that dependency outputs can be mapped and templated. In this implementation only the "old" format is implemented,
${outputs.OUTPUT_NAME}
is not supported yet, but will be implemented in a follow-up PR, where the documentation also would be updated.What issue does it fix
Closes no issues but is a precursor to #2662
Notes for the reviewer
Checklist