Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed typo in comments #2997

Merged
merged 2 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/porter/build.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func (o *BuildOptions) Validate(p *Porter) error {
return fmt.Errorf("invalid --driver value %s", o.Driver)
}

// Syncing value back to the config and we will always use the config
// Syncing value back to the config, and we will always use the config
// to determine the driver
// This would be less awkward if we didn't do an automatic build during publish
p.Data.BuildDriver = o.Driver
Expand Down
2 changes: 1 addition & 1 deletion pkg/porter/lifecycle.go
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@ func (o *BundleExecutionOptions) defaultDriver(p *Porter) {
//
// When you run porter installation apply, there are some settings from porter install
// that aren't exposed as flags (like driver and allow-docker-host-access).
// This allows the user to set them in the config file and we will use them before running the bundle.
// This allows the user to set them in the config file, and we will use them before running the bundle.
//

// Apply global config to the --driver flag
Expand Down
2 changes: 1 addition & 1 deletion pkg/porter/list.go
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func (d DisplayInstallation) ConvertToInstallation() (storage.Installation, erro
return i, nil
}

// ConvertParamToSet converts a Parameters into a internal ParameterSet.
// ConvertParamToSet converts a Parameters into an internal ParameterSet.
func (d DisplayInstallation) ConvertParamToSet() (storage.ParameterSet, error) {
strategies := make([]secrets.SourceMap, 0, len(d.Parameters))
for name, value := range d.Parameters {
Expand Down
2 changes: 1 addition & 1 deletion pkg/porter/publish.go
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ func (o *PublishOptions) validateTag() error {
}

// Publish is a composite function that publishes an invocation image, rewrites the porter manifest
// and then regenerates the bundle.json. Finally it publishes the manifest to an OCI registry.
// and then regenerates the bundle.json. Finally, it publishes the manifest to an OCI registry.
func (p *Porter) Publish(ctx context.Context, opts PublishOptions) error {
ctx, log := tracing.StartSpan(ctx)
defer log.EndSpan()
Expand Down
2 changes: 1 addition & 1 deletion pkg/porter/reconcile.go
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ func (p *Porter) IsInstallationInSync(ctx context.Context, i storage.Installatio
}
}

// We want to upgrade but we don't have values to compare against
// We want to upgrade, but we don't have values to compare against
// This shouldn't happen but check just in case
if lastRun == nil {
log.Info("Triggering because the last run for the installation wasn't recorded")
Expand Down
Loading