Skip to content

Commit

Permalink
Update theme to V2 (#7)
Browse files Browse the repository at this point in the history
* feat: upgrade theme to spicetify v2

* docs: fix git clone instructions

* fix: button-active text is now visible

* fix: change colors to match omni palette

* docs: use LICENSE from omni template and fix typos

* fix: selected-row color was hard to see

* fix: lyrics color was not being applied

* docs: update omni theme screenshot

* fix: css lyrics background var missing

* fix: lyrics inactive color not being displayed
  • Loading branch information
ianlibanio authored Jan 19, 2023
1 parent 1c8cbf9 commit 86ac565
Show file tree
Hide file tree
Showing 9 changed files with 797 additions and 2,035 deletions.
41 changes: 12 additions & 29 deletions INSTALL.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
### [Spicetify](https://github.com/khanhas/spicetify-cli)
### [Spicetify v2](https://github.com/khanhas/spicetify-cli)

#### Linux and MacOS:

In **Bash**:

```bash
cd "$(dirname "$(spicetify -c)")/Themes"
git clone https://github.com/getomni/spicetify.git omni
git clone -b v2 https://github.com/getomni/spicetify.git omni
cd omni
cp omni.js ~/spicetify-cli/Extensions
cp omni.js ../../Extensions/.
spicetify config extensions omni.js
spicetify config current_theme omni color_scheme base
spicetify config inject_css 1 replace_colors 1 overwrite_assets 1
Expand All @@ -21,7 +21,7 @@ In **Powershell**:

```powershell
cd "$(spicetify -c | Split-Path)\Themes"
git clone https://github.com/getomni/spicetify.git omni
git clone -b v2 https://github.com/getomni/spicetify.git omni
cd omni
Copy-Item omni.js ..\..\Extensions
spicetify config extensions omni.js
Expand All @@ -30,6 +30,14 @@ spicetify config inject_css 1 replace_colors 1 overwrite_assets 1
spicetify apply
```

From Spotify > v1.1.62, in sidebar, they use an adaptive render mechanic to actively show and hide items on scroll. It helps reducing number of items to render, hence there is significant performance boost if you have a large playlists collection. But the drawbacks is that item height is hard-coded, it messes up user interaction when we explicity change, in CSS, playlist item height bigger than original value. So you need to add these 2 lines in Patch section in config file:

```ini
[Patch]
xpui.js_find_8008 = ,(\w+=)32,
xpui.js_repl_8008 = ,${1}56,
```

#### Hide Window Controls

Windows user, please edit your Spotify shortcut and add flag `--transparent-window-controls` after the Spotify.exe:
Expand All @@ -49,28 +57,3 @@ Remove the omni script with the following commands
spicetify config extensions omni.js-
spicetify apply
```

#### `color.ini` reference

These keys are used in the `colors.ini` file.

| Key | Target |
| --------------------------------------- | ------------------------------------------------------------------------- |
| `main_fg` | The main Accent, used for sidebar and some interface elements |
| `main_bg` | The real star of the show, the main Background of app (on the right side) |
| `secondary_fg` | Main text and some other small stuff |
| `secondary_bg` | The background for the left side navbar |
| `selected_button` | Button currently being hovered |
| `pressing_fg` | The color that momentarily appears when you press anything |
| `pressing_button_fg` | The textcolor for a pressed button |
| `pressing_button_bg` | BG color for the pressed button |
| `sidebar_and_player_bg` | Background for the player |
| `sidebar_indicator_and_hover_button_bg` | For the slider & selected items when you hover over it |
| `cover_overlay_and_shadow` | Overlay for when you hover over the album covers |
| `slider_bg` | The background for the slider |
| `scrollbar_fg_and_selected_row_bg` | Color for the current selected row |
| `active_control_fg` | Foreground for active control items |
| `indicator_fg_and_button_bg` | Button text color |
| `miscellaneous_bg` | The background color of toolips ("You're offline" etc) |
| `miscellaneous_hover_bg` | Hover Color for the Tooltips |
| `preserve_1` | Misc text colors |
675 changes: 5 additions & 670 deletions LICENSE.md

Large diffs are not rendered by default.

21 changes: 13 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
<br>
<img src="https://storage.googleapis.com/golden-wind/github/omni/omni.png" alt="Omni Logo" width="100">
<br>
Omni for <a href="https://github.com/khanhas/spicetify-cli">Spicetify</a>
Omni for <a href="https://github.com/khanhas/spicetify-cli">Spicetify v2</a>
<br>
</h1>

<p align="center">
<strong>Dark theme for <a href="https://github.com/khanhas/spicetify-cli">Spicetify</a></strong>
<strong>Dark theme for <a href="https://github.com/khanhas/spicetify-cli">Spicetify v2</a></strong>
</p>

<p align="center">
Expand All @@ -17,6 +17,7 @@
</p>

<p align="center">
<a href="#info">Info</a> •
<a href="#install">Install</a> •
<a href="#team">Team</a> •
<a href="#license">License</a>
Expand All @@ -26,22 +27,26 @@
<img alt="Omni screnshoot for Spicetify" src="./screenshot.png">
</p>

## Info

With the new versions of Spotify and Spicetify the main branch theme became outdated and doesn't work anymore. Using this version (v2), you can enjoy all Spotify functionalities from new releases using the Omni theme.

## Install

All instructions can be found at [INSTALL.md](./INSTALL.md).

## Team

This theme is maintained by the following person(s) and a bunch of [awesome contributors](https://github.com/getomni/spicetify/graphs/contributors).
This theme version (v2) is maintained by the following person(s) and a bunch of [awesome contributors](https://github.com/getomni/spicetify/graphs/contributors).

| [![João Inácio](https://github.com/birobirobiro.png?size=100)](https://github.com/birobirobiro) |
| ----------------------------------------------------------------------------------------------- |
| [João Inácio](https://github.com/birobirobiro) |
| [![Ian Libânio](https://github.com/ianlibanio.png?size=100)](https://github.com/ianlibanio) |
| ------------------------------------------------------------------------------------------- |
| [Ian Libânio](https://github.com/ianlibanio) |

## License

[GPL-3.0 License](./LICENSE.md)
[MIT License](./LICENSE.md)

---

Based on [Dribbblish](https://github.com/morpheusthewhite/spicetify-themes/tree/master/Dribbblish)
Based on [Dribbblish v2](https://github.com/morpheusthewhite/spicetify-themes/tree/v2/Dribbblish)
Binary file modified assets/glue-resources/fonts/Roboto.woff2
Binary file not shown.
Binary file modified assets/glue-resources/fonts/RobotoMedium.woff2
Binary file not shown.
32 changes: 16 additions & 16 deletions color.ini
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
[base]
main_fg =E1E1E6
secondary_fg =E1E1E6
main_bg =191622
sidebar_and_player_bg =191622
cover_overlay_and_shadow =000000
indicator_fg_and_button_bg =5A4B81
pressing_fg =FF5C86
slider_bg =191622
sidebar_indicator_and_hover_button_bg =F7F7FB
scrollbar_fg_and_selected_row_bg =5A4B81
pressing_button_fg =F7F7FB
pressing_button_bg =191622
selected_button =67e480
miscellaneous_bg =5A4B81
miscellaneous_hover_bg =5A4B81
preserve_1 =FFFFFF
text = E1E1E6
subtext = E1E1E6
sidebar-text = F7F7FB
main = 191622
sidebar = 191622
player = 191622
card = 191622
shadow = 000000
selected-row = 988BC7
button = 5A4B81
button-active = 988BC7
button-disabled = 5A4B81
tab-active = 5A4B81
notification = 5A4B81
notification-error = E96379
misc = FFFFFF
Loading

0 comments on commit 86ac565

Please sign in to comment.