Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force glide to keep original image sizes #6417

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

grzesiek2010
Copy link
Member

@grzesiek2010 grzesiek2010 commented Sep 14, 2024

Closes #6293

Why is this the best possible solution? Were any other approaches considered?

I'm not sure why Glide alters the image sizes on subsequent loads (it might be a bug), but this change ensures they retain their original dimensions.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Please verify that the bug is fixed and ensure images load correctly, not just in selects but also in image widgets - everywhere else images are used.

Do we need any specific form for testing your changes? If so, please attach one.

No.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • added or modified tests for any new or changed behavior
  • run ./gradlew connectedAndroidTest (or ./gradlew testLab) and confirmed all checks still pass
  • added a comment above any new strings describing it for translators
  • added any new strings with date formatting to DateFormatsTest
  • verified that any code or assets from external sources are properly credited in comments and/or in the about file.
  • verified that any new UI elements use theme colors. UI Components Style guidelines

@grzesiek2010 grzesiek2010 merged commit 989ae30 into getodk:master Sep 24, 2024
6 checks passed
@dbemke
Copy link

dbemke commented Sep 30, 2024

Tested with Success!

Verified on a device with Androids 10

Verified cases:

@WKobus
Copy link

WKobus commented Sep 30, 2024

Tested with Success

Verified on device with Android 14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing images after using search in selects with images and no buttons
4 participants