Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev: docker-compose: expose redis locally #887

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

alxndrsn
Copy link
Contributor

@alxndrsn alxndrsn commented Feb 8, 2025

Allowing access to enketo's redis instances locally allows this docker-compose environment to be used to work on enketo-express as well as other central services:

  1. run in this repo:

    make stop && make dev && docker compose stop enketo

  2. run in enketo repo:

    yarn workspace enketo-express grunt develop

What has been done to verify that this works as intended?

Tested locally.

Why is this the best possible solution? Were any other approaches considered?

No other approaches considered.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

No effect.

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No.

Before submitting this PR, please make sure you have:

  • branched off and targeted the next branch OR only changed documentation/infrastructure (master is stable and used in production)
  • verified that any code or assets from external sources are properly credited in comments or that everything is internally sourced

Allowing access to enketo's redis instances locally allows this docker-compose environment to be used to work on enketo-express as well as other central services:

1. run in this repo:

	make stop && make dev && docker compose stop enketo

2. run in `enketo` repo:

	yarn workspace enketo-express grunt develop
@alxndrsn alxndrsn requested a review from sadiqkhoja February 8, 2025 09:09
@alxndrsn alxndrsn merged commit bfde2de into getodk:next Feb 14, 2025
2 checks passed
@alxndrsn alxndrsn deleted the dev-expose-redis-ports branch February 14, 2025 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants