ci: move all testing to GitHub Actions #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* allow conditionally building docker containers and uploading them to GHCR, depending on test results * progress towards getodk#677 using pre-built docker images in the root docker-compose.yml
2 tasks
lognaturel
approved these changes
Feb 12, 2025
alxndrsn
added a commit
that referenced
this pull request
Feb 13, 2025
Noted while working on #882: `files/postgres/upgrade-postgres.sh` is not actually run with `/bin/bash -eu` as its shebang declares, but with `/bin/sh`. ----- This commit 1. fixes the shell used for `upgrade-postgres.sh` 2. introduces a test which would have detected this issue, and should prevent similar issues in future 3. fixes use of deprecated dockerfile syntax detected by the new test 4. pulls `shellcheck` invocation into a script file to allow easier use locally, and possible future extension ----- Docker build checks Currently in beta, "docker build checks" are best-practice lint checks for dockerfiles. See: https://docs.docker.com/build/checks/#check-a-build-without-building ----- Dockerfile fixes * `postgres-upgrade.dockerfile`: https://docs.docker.com/reference/build-checks/json-args-recommended/ * `postgres14.dockerfile`: https://docs.docker.com/go/dockerfile/rule/legacy-key-value-format/ ----- Related: #342
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress towards #677 - this will eventually allow the GHCR upload job to depend on the outcome of tests previously run in CircleCI.
What has been done to verify that this works as intended?
Run github actions
Why is this the best possible solution? Were any other approaches considered?
Alternative could be moving everything to CircleCI, but that probably wouldn't simplify uploading images to GitHub Container Registry (GHCR)
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Should not affect users.
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Should not require documentation updates.
Before submitting this PR, please make sure you have:
nextbranch OR only changed documentation/infrastructure (masteris stable and used in production)