Change pyxform-http port because macOS uses port 5000 for ControlCenter #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Looks good to me! I don't think anything else needs to change. We specify a different port in production, so everything should be fine there: https://github.com/getodk/central/blob/774b491961578bd6e03ceaa6cf8032dd27b828a7/files/service/config.json.template#L26. Feel free to merge!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated pyxform-http's port to 5000 to match Central's docs because of #1000.
But that broke running pyxform-http on macOS because port 5000 is used by ControlCenter.
So, I'll be reverting the pyxform-http change, but I think we should also make this change here. I say think because I have no idea the implications for this change in Central.