Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate yapsy compatibility function names. #3730

Conversation

aknrdureegaesr
Copy link
Contributor

Pull Request Checklist

  • I’ve read the guidelines for contributing.
  • I updated AUTHORS.txt and CHANGES.txt (if the change is non-trivial) and documentation (if applicable). Not applicable.
  • I tested my changes.

Description

Output a deprecation warning for people that use the old, Yapsy function names, so those can eventually be removed.

It is ok with me if my work is in the end squashed into one commit, together with the other work on the new-plugin-mananger branch.

@Kwpolska
Copy link
Member

Kwpolska commented Jan 5, 2024

Sorry, but the proposed implementation is far too complicated. Only two plugins use this now, I’ll implement something to show a warning unconditionally instead of showing it only once and with traceback magic.

@Kwpolska Kwpolska closed this Jan 5, 2024
@aknrdureegaesr
Copy link
Contributor Author

Fine with me.

Only two plugins use this now,

Epistemological remark: I don't think you can know all Nikola plugins 🤓.

@Kwpolska
Copy link
Member

Kwpolska commented Jan 5, 2024

Epistemological remark: I don't think you can know all Nikola plugins 🤓.

Well, two plugins in the getnikola/plugins repository :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants