Admin: Ruff formatting #8445
Merged
Admin: Ruff formatting #8445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
force-pushed
the
admin/ruff-formatting
branch
2 times, most recently
from
e151ffc to
c9cc24f
Compare
bblommers
force-pushed
the
admin/ruff-formatting
branch
from
c9cc24f to
661b2b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8445 +/- ##
==========================================
- Coverage 94.60% 92.62% -1.98%
==========================================
Files 1168 1225 +57
Lines 101707 105633 +3926
==========================================
+ Hits 96220 97843 +1623
- Misses 5487 7790 +2303
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff complains about the formatting of a
type: ignoreall of a sudden.I've tried upgrading ruff, which would improve the formatting - but the new formatting is not compatible with Python 3.8. So we can't do that yet.