Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamoDB: KeyConditionExpression can have additional parentheses #8444

Merged

Conversation

bblommers
Copy link
Collaborator

Fixes #8414

@bblommers bblommers added this to the 5.0.26 milestone Dec 28, 2024
@bblommers bblommers force-pushed the dynamodb-key-condition-with-brackets branch from ebb9a4d to 14085ab Compare December 29, 2024 19:38
Copy link

codecov bot commented Dec 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (9fa5890) to head (14085ab).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8444   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files        1225     1225           
  Lines      105633   105635    +2     
=======================================
+ Hits        97843    97845    +2     
  Misses       7790     7790           
Flag Coverage Δ
servertests 27.76% <100.00%> (+<0.01%) ⬆️
unittests 92.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bblommers bblommers marked this pull request as ready for review December 30, 2024 10:42
@bblommers bblommers merged commit 51313ce into getmoto:master Dec 30, 2024
53 checks passed
@bblommers bblommers deleted the dynamodb-key-condition-with-brackets branch December 30, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DynamoDB KeyExpression are not evaluated the right way
1 participant