Create RDS test clients with fixture #8406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and standardize on "client" instead of "conn". These tests now run in a different region, but they are still passing.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8406 +/- ##
=======================================
Coverage 92.62% 92.62%
=======================================
Files 1225 1225
Lines 105633 105655 +22
=======================================
+ Hits 97843 97865 +22
Misses 7790 7790
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
I'll look into what's breaking the server tests, I can reproduce the issue locally. |
...so that tests pass with TEST_SERVER_MODE=true.
|
Test failure seems unrelated to my changes. @bpandola Please review again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create RDS test clients with a fixture to get rid of copy&paste code in the tests. The variable is now consistently called
client.