Make library work on clang on windows #57
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #56.
As described in that issue, the
function_name()
obtained fromstd::source_location
on clang on windows does not include template parameters, which means the tricks used by the library to determine names automatically just don't work. However,__PRETTY_FUNCTION__
does contain the template parameters and gives the exact string we wanted.This works whether running clang directly on Windows or whether via
clang-cl
, since both__clang__
and_MSC_VER
are defined in either case.I did a few tests of some basic functionality of the library and everything seemed to work as expected now.