Add operator== to TaggedUnion.hpp

[ttamttam]

Following @liuzicheng1987 advice (#272 (comment)), I had a hard time converting my code in order to have it work in TaggedUnion.hpp.

Note sure at all that it is OK?

Best regards

[liuzicheng1987]

Looks good to me...the only thing I could think of is to maybe add a test. (Just put it with the JSON tests.)

[ttamttam]

I thank you. I'll add tests. But i won't be able to before the end of the year.

[ttamttam]

@liuzicheng1987
I just added some test.
Best regards

[liuzicheng1987]

Hi @ttamttam

thanks for adding the tests. Sorry it took me four days to respond, I must habe somehow missed it. The tests look great. I will run them and (if everything goes well) then merge.

[liuzicheng1987]

Hi @ttamttam,

compilation has failed.

I think you need to just rearrange the code a bit: Just put the struct declaration before the declaration of the operator()== and you should be fine.

I promise next time I will be faster to review the changes.

[ttamttam]

no problem. thanks. won't be able to do that before the week-end. tschuess 4 déc. 2024 09:14:36 Dr. Patrick Urbanke (劉自成) ***@***.***>:

…

Hi @ttamttam[https://github.com/ttamttam], compilation has failed. I think you need to just rearrange the code a bit: Just put the struct declaration before the declaration of the operator()== and you should be fine. I promise next time I will be faster to review the changes. — Reply to this email directly, view it on GitHub[#280 (comment)], or unsubscribe[https://github.com/notifications/unsubscribe-auth/AAAM4HBO5CSLZGJHV426FFL2D22WXAVCNFSM6AAAAABSMNHONWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJWGUYDCMZVGA]. You are receiving this because you were mentioned. [Image de pistage][https://github.com/notifications/beacon/AAAM4HD5PW53HXKBW3HTB2T2D22WXA5CNFSM6AAAAABSMNHONWWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTUV73BWM.gif]

[liuzicheng1987]

@ttamttam , looks great! Thank you for your contribution!