Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: yarn -> pnpm #1976

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

feat: yarn -> pnpm #1976

wants to merge 20 commits into from

Conversation

stephenlago99
Copy link
Collaborator

Replace yarn with pnpm to improve the dependency installation speeds.

@stephenlago99 stephenlago99 self-assigned this Jan 8, 2025
@stephenlago99 stephenlago99 marked this pull request as draft January 9, 2025 09:24
@stephenlago99
Copy link
Collaborator Author

Converted this to a draft since some tasks with more priority came in.

To wrap this up, only the following need to be done:

  • Fix .github/workflows/cypress.ts by caching the Cypress binary between runs (currently it's failing because it can't find the binary)

Suggestion:

      - name: Cache Cypress binary
        uses: actions/cache@v3
        with:
          path: ~/.cache/Cypress
          key: cypress-binary-${{ hashFiles('pnpm-lock.yaml') }}
          restore-keys: |
            cypress-binary-
  • Fix .github/workflows/codegen.ts by waiting until the graphql endpoint is up (currently it's failing because the install takes just a few seconds and when codegen is ran the API is not up yet)

Suggestion:

      - name: Launch API
        run: docker compose -f ./ci/docker-compose.ci.yml --env-file ./.env up -d api

      - name: Wait for API to be ready
        run: |
          timeout 60s bash -c '
          until curl -s -f -o /dev/null "http://localhost:3000/graphql"; do
            echo "Waiting for API to be ready..."
            sleep 2
          done
          '

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant