fix(unique-jobs): Unique jobs were not enqueuing jobs with keyword args #2857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivannovosad
force-pushed
the
fix-unique
branch
from
6e39430 to
b8c53ae
Compare
brunomiguelpinto
approved these changes
Nov 25, 2024
ivannovosad
force-pushed
the
fix-unique
branch
3 times, most recently
from
40b78af to
27ca595
Compare
ivannovosad
force-pushed
the
fix-unique
branch
from
27ca595 to
1b11586
Compare
nudded
requested changes
Nov 25, 2024
| def perform(charge:, event:, billing_at: nil) | ||
| unique :until_executed, on_conflict: :log | ||
|
|
||
| def perform(charge, event, billing_at = nil) |
There was a problem hiding this comment.
@ivannovosad why is this needed?
There was a problem hiding this comment.
(the removal of keyword arguments that is)
vincent-pochet
requested changes
Nov 25, 2024
There was a problem hiding this comment.
What are we trying to solve here?
veeqo/activejob-uniqueness#75 does not mention keyword arguments, could you elaborate a bit on what is the issue?
Also, pay in advance billing job is no more unique in production? This feels a bit dangerous
|
The issue was that jobs were not enqueued even if we tried to enqueue one job (this shouldn't have any issues regarding uniqueness). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
There is a activejob-uniqueness bug that does not enqueue integration jobs when using named arguments.
This PR fixes that.