Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access permissions 6: Complete test cases #6882

Open
wants to merge 1 commit into
base: v5/feature/access-permissions-5
Choose a base branch
from

Conversation

lukasbestle
Copy link
Member

@lukasbestle lukasbestle commented Dec 23, 2024

🚨 Merge first

Description

Summary of changes

Add missing provider cases for existing permissions

Reasoning

We have added these permissions since creating these tests and seem to have forgotten to add them here as well.

Additional context

Clearing the cache is needed for PageBlueprint tests because we reuse the same blueprint names with different options. Ideally we would clear the cache after every test in the Cms namespace, but for some reason many test classes inherit from Kirby\TestCase instead of Kirby\Cms\TestCase, thus making it hard to find a good place for this.

Changelog

None (too small of a change to be relevant)

Docs

None

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

We have added these permissions since creating these tests and seem to have forgotten to add them here as well
@lukasbestle lukasbestle added the type: refactoring ♻️ Is about bad code; cleans up code label Dec 23, 2024
@lukasbestle lukasbestle added this to the 5.0.0-beta.2 milestone Dec 23, 2024
@lukasbestle lukasbestle requested a review from a team December 23, 2024 21:20
@lukasbestle lukasbestle self-assigned this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactoring ♻️ Is about bad code; cleans up code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant