Access permissions 2: New LanguagePermissions class
#6876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ahmet Bora <[email protected]>
Without having a current user, the permission would be `false` even if the logic test in `canChangeRole()` would not work, thus making the test useless; in fact just adding the impersonation made the test fail because manually creating a user object didn’t trigger the `isLastAdmin()` logic
lukasbestle
force-pushed
the
v5/feature/access-permissions-2
branch
from
bcf32ce to
2be7d6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Refactor out the permission handling for
Cms\LanguageintoLanguagePermissionsto be consistent with otherModelPermissionsclassesReasoning
Consistency when we add additional permissions for languages
Changelog
Refactoring
ModelPermissionsnow also supportsLanguageobjects as quasi modelsLanguagePermissionsclass that inherits the existing logic fromLanguageRulesfor consistency with other modelsBreaking changes
None
Docs
None
Ready?
For review team
Add lab and/or sandbox examples (wherever helpful)