Access permissions 1: Refactor access to roles #6874
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
$app->role()
method is mainly a shortcut to$app->user()?->role()
for us, but can also be used to directly access a specific role object.Reasoning
Following PRs would add significantly more uses of
$app->user()?->role()
that can be shortened and DRYed by this.Changelog
Features
$app->role()
method that works like$app->user()
to return a specific role or the role of the current user.Housekeeping
$app->roles()
method to theAppUsers
trait to increase the overviewBreaking changes
None
Docs
None (automatically documented via reference)
Ready?
For review team
Add lab and/or sandbox examples (wherever helpful)