Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow disable all page buttons via buttons: false #6858

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Allow disable all page buttons via buttons: false #6858

merged 1 commit into from
Dec 10, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Dec 10, 2024 •
edited by distantnative
Loading

Changelog

Enhancement

  • Allow disable all page buttons via buttons: false

Breaking changes

None

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added the type: enhancement ✨ Suggests an enhancement; improves Kirby label Dec 10, 2024
@afbora afbora added this to the 5.0.0-beta.2 milestone Dec 10, 2024
@afbora afbora requested review from distantnative and a team December 10, 2024 10:55
@afbora afbora self-assigned this Dec 10, 2024
@afbora afbora linked an issue Dec 10, 2024 that may be closed by this pull request
[v5] Allow buttons: false in blueprints to disable all page buttons #6853
Closed
bastianallgeier
bastianallgeier approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @distantnative should have another look at it.

@distantnative distantnative merged commit c8c7664 into v5/develop Dec 10, 2024
12 checks passed
@distantnative distantnative deleted the fix/6853-allow-disable-all-page-buttons branch December 10, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

@distantnative distantnative Awaiting requested review from distantnative

Assignees

@afbora afbora

Labels
type: enhancement ✨ Suggests an enhancement; improves Kirby
Projects
None yet
Milestone
5.0.0-beta.2
Development

Successfully merging this pull request may close these issues.

[v5] Allow buttons: false in blueprints to disable all page buttons
3 participants
@afbora @bastianallgeier @distantnative