Fix for homepage preview URLs on proper domains #6856
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Summary of changes
Reasoning
Sites on real domains have their homepage on
https://example.com
and nothttps://example.com/
. The unit tests did not catch this because they all used/
as site index URL, which naturally does not have this trailing slash problem.Additional context
Today's quickfix by Basti passes all those tests as well. 🎉
So I think releasing a beta 2 with this PR isn't urgent at all. I decided to change the code mainly for readability and future robustness (Basti's fix only works because the
Uri
class normalizes the trailing slash as well, but we can't rely on that here).Changelog
Refactoring (since beta 1, not for final release notes)
Docs
None
Ready?
For review team
Add lab and/or sandbox examples (wherever helpful)