Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alt attribute for FileVersion instances #6855

Merged
merged 1 commit into from
Dec 10, 2024
Merged

Fix alt attribute for FileVersion instances #6855

merged 1 commit into from
Dec 10, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Dec 9, 2024 •
edited by bastianallgeier
Loading

Description

If a file is cropped/resized, the FileVersion instance is used. We can get the original model from FileVersion::original() method.

Changelog

Fixes

Breaking changes

None

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added the type: bug 🐛 Is a bug; fixes a bug label Dec 9, 2024
@afbora afbora added this to the 4.6.0 milestone Dec 9, 2024
@afbora afbora requested a review from a team December 9, 2024 19:02
@afbora afbora self-assigned this Dec 9, 2024
@afbora afbora linked an issue Dec 9, 2024 that may be closed by this pull request
Alt attribute lost after resize/crop #6852
Closed
bastianallgeier
bastianallgeier approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@bastianallgeier bastianallgeier merged commit 7efb01f into develop-minor Dec 10, 2024
13 checks passed
@bastianallgeier bastianallgeier deleted the fix/6852-file-version-alt-attribute branch December 10, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

Assignees

@afbora afbora

Labels
type: bug 🐛 Is a bug; fixes a bug
Projects
None yet
Milestone
4.6.0
Development

Successfully merging this pull request may close these issues.

Alt attribute lost after resize/crop
2 participants
@afbora @bastianallgeier