-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Writer toolbar: hide when no buttons #6846
Writer toolbar: hide when no buttons #6846
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the target branch be develop-minor
for 4.6.0?
@afbora not necessarily. We put everything that could be released in a patch release on |
I'm totally fine to include it in the patch release, but I think we should remove the :has change in that case, right? |
You're right, we only started adding |
@bastianallgeier I'd suggest then to move it to v5. I think it's rather complicated to fix this without |
@distantnative can you fix the conflicts? |
4b810c1
to
33138ee
Compare
33138ee
to
fb4a468
Compare
@bastianallgeier done |
Changelog
Fixes
Ready?
Unit tests for fixed bug/featureFor review team