Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for old locks #6816

Merged
merged 8 commits into from
Nov 28, 2024
Merged

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Nov 26, 2024

Summary of changes

  • New Lock::legacy() method to return a lock instance based on an old .lock file
  • New Lock::legacyFile() method to return an absolute path to an old lock file based on the model
  • The PreviewView now shows a custom message for old lock states because it cannot display the current changes from other users.
  • New cleanup method in the Changes controller to remove old lock files as soon as new changes are stored or discarded

@bastianallgeier bastianallgeier force-pushed the v5/changes/support-for-old-locks branch from 21373ab to c2d056d Compare November 26, 2024 11:53
src/Api/Controller/Changes.php Show resolved Hide resolved
src/Content/Lock.php Outdated Show resolved Hide resolved
@bastianallgeier bastianallgeier force-pushed the v5/changes/support-for-old-locks branch from d8aafa6 to b9f78e3 Compare November 27, 2024 12:14
@bastianallgeier bastianallgeier marked this pull request as ready for review November 27, 2024 13:13
@bastianallgeier bastianallgeier merged commit ccd1b14 into v5/develop Nov 28, 2024
13 checks passed
@bastianallgeier bastianallgeier deleted the v5/changes/support-for-old-locks branch November 28, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants