Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EULA to 2024-11-12 #6790

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Update EULA to 2024-11-12 #6790

merged 1 commit into from
Nov 14, 2024

Conversation

lukasbestle
Copy link
Member

PR to main as this is independent of a release. We could also merge it to the 4.5 release branch if needed.

@lukasbestle lukasbestle added the type: docs 📝 Is about documentation; adds documentation label Nov 12, 2024
@lukasbestle lukasbestle self-assigned this Nov 12, 2024
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with merging it now.

@lukasbestle
Copy link
Member Author

Ah, doesn't work because this doesn't come from a release branch, so the release CI workflows are not executed. I think we need to merge this into the 4.5 release branch first. Speaking of which, is there one? Can't find one.

@distantnative
Copy link
Member

@lukasbestle I don't think it exists but could be created from the 4.5.0-rc.1 tag

@lukasbestle lukasbestle changed the base branch from main to release/4.5.0 November 14, 2024 19:10
@lukasbestle lukasbestle merged commit 76fa391 into release/4.5.0 Nov 14, 2024
10 of 13 checks passed
@lukasbestle lukasbestle deleted the feature/eula-update branch November 14, 2024 19:13
@lukasbestle lukasbestle added this to the 4.5.0 milestone Nov 14, 2024
@lukasbestle
Copy link
Member Author

Now we just need to remember to use the release branch for the final 4.5.0 release :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs 📝 Is about documentation; adds documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants