Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix site/tree/parents request for link dialogs #6642

Merged
merged 1 commit into from
Sep 1, 2024
Merged

Fix site/tree/parents request for link dialogs #6642

merged 1 commit into from
Sep 1, 2024

Conversation

afbora
Copy link
Member

@afbora afbora commented Aug 27, 2024 •
edited by distantnative
Loading

Changelog

Fixes

Breaking changes

None

Docs

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add lab and/or sandbox examples (wherever helpful)
  • Add changes & docs to release notes draft in Notion

@afbora afbora added this to the 4.4.0 milestone Aug 27, 2024
@afbora afbora requested review from distantnative and a team August 27, 2024 14:03
@afbora afbora self-assigned this Aug 27, 2024
@afbora afbora linked an issue Aug 27, 2024 that may be closed by this pull request
Link dialog: The request to tree/parents failed #6627
Closed
@distantnative
Copy link
Member

@afbora this needs to point towards release/4.4.0 as develop-minor already has 4.5 changes on it.

@afbora afbora force-pushed the fix/6627-site-tree-parents branch from 1adc513 to abae310 Compare September 1, 2024 11:13
@afbora afbora changed the base branch from develop-minor to release/4.4.0 September 1, 2024 11:13
@afbora afbora force-pushed the fix/6627-site-tree-parents branch from abae310 to 2cffe1d Compare September 1, 2024 11:15
@afbora afbora force-pushed the fix/6627-site-tree-parents branch from 2cffe1d to c654ea7 Compare September 1, 2024 11:15
@afbora
Copy link
Member Author

afbora commented Sep 1, 2024

@distantnative Now, is it OK?

distantnative
distantnative approved these changes Sep 1, 2024
View reviewed changes
Copy link
Member

@distantnative distantnative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works now well for #6627

@distantnative distantnative merged commit 07185d2 into release/4.4.0 Sep 1, 2024
15 of 16 checks passed
@distantnative distantnative deleted the fix/6627-site-tree-parents branch September 1, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@distantnative distantnative distantnative approved these changes

Assignees

@afbora afbora

Labels
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Link dialog: The request to tree/parents failed
2 participants
@afbora @distantnative