Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes 21: Render Mode #6593

Merged
merged 8 commits into from
Aug 13, 2024
Merged

Conversation

bastianallgeier
Copy link
Member

@bastianallgeier bastianallgeier commented Jul 31, 2024

Description

Summary of changes

  • New VersionId::$render property
  • Use new render mode in ModelWithContent::content method
  • Use changes Version in Panel\Model::content() if it exists, to show changes in the panel.

Ready?

  • In-code documentation (wherever needed)
  • Unit tests for fixed bug/feature
  • Tests and CI checks all pass

For review team

  • Add changes & docs to release notes draft in Notion

@bastianallgeier bastianallgeier changed the base branch from main to v5/develop July 31, 2024 14:44
@bastianallgeier bastianallgeier added this to the 5.0.0-alpha.2 milestone Aug 2, 2024
@bastianallgeier bastianallgeier marked this pull request as ready for review August 2, 2024 09:28
src/Panel/Page.php Outdated Show resolved Hide resolved
@bastianallgeier bastianallgeier force-pushed the v5/changes/21-render-mode branch from 41df035 to 44feac1 Compare August 12, 2024 09:24
src/Cms/ModelWithContent.php Outdated Show resolved Hide resolved
src/Panel/Model.php Show resolved Hide resolved
@bastianallgeier bastianallgeier merged commit b9958ee into v5/develop Aug 13, 2024
11 checks passed
@bastianallgeier bastianallgeier deleted the v5/changes/21-render-mode branch August 13, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants