Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.1.2 #6330

Merged
merged 19 commits into from
Mar 6, 2024
Merged

4.1.2 #6330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
8a4b761
Wrap custom commands in another anonymous function to fix the binding…
bastianallgeier Feb 29, 2024
7c0edcd
Don’t throw an exception if a model for a UUID cannot be found
bastianallgeier Feb 29, 2024
d2eb35f
Don’t redeclare the dump helper if it already exists
bastianallgeier Feb 29, 2024
7da18de
Merge pull request #6313 from getkirby/fix/6165-failsafe-permalinks-t…
bastianallgeier Feb 29, 2024
795a6c4
Merge pull request #6314 from getkirby/fix/6250-skip-dump
bastianallgeier Feb 29, 2024
780763d
Fix emoji overflow issue in k-icon-frame
bastianallgeier Feb 29, 2024
d0f326f
Merge pull request #6315 from getkirby/fix/6222-icon-overflow
distantnative Feb 29, 2024
5b46304
Fix inline docs
distantnative Feb 29, 2024
e981493
Suppress warnings in remote class if system CA is outside of open_bas…
bastianallgeier Mar 1, 2024
a4e6be6
Sanity check for the file id in the toFiles method
bastianallgeier Mar 1, 2024
6b32e65
Merge pull request #6310 from getkirby/fix/6039-custom-textarea-buttons
bastianallgeier Mar 1, 2024
b6ebf92
Merge pull request #6318 from getkirby/fix/unstable-to-files-method
distantnative Mar 1, 2024
43596df
Merge pull request #6316 from getkirby/fix/6236-license-ssl-issue
distantnative Mar 1, 2024
d11ba2f
Fix tables in the object field and license dialog
bastianallgeier Mar 5, 2024
ea5543e
Fix overflowing
bastianallgeier Mar 5, 2024
47b1952
Use the css fix from the issue for the object field
bastianallgeier Mar 5, 2024
94d8e8e
Update `shivammathur/cache-extensions` (use ref sha)
afbora Mar 5, 2024
c55a668
Merge pull request #6327 from getkirby/fix/table-cell-fix
bastianallgeier Mar 6, 2024
f580c76
Preflight for 4.1.2
bastianallgeier Mar 6, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/backend.yml
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ jobs:

- name: Setup PHP cache environment
id: ext-cache
uses: shivammathur/cache-extensions@a167dc27e7329e600b4fffbbbc8b01b9221ab923 # pin@v1
uses: shivammathur/cache-extensions@f9643262bed1015eb7bfad95e63378b23bc2d319 # pin@v1
with:
php-version: ${{ matrix.php }}
extensions: ${{ env.extensions }}
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:

- name: Setup PHP cache environment
id: ext-cache
uses: shivammathur/cache-extensions@a167dc27e7329e600b4fffbbbc8b01b9221ab923 # pin@v1
uses: shivammathur/cache-extensions@f9643262bed1015eb7bfad95e63378b23bc2d319 # pin@v1
with:
php-version: ${{ env.php }}
extensions: ${{ env.extensions }}
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"description": "The Kirby core",
"license": "proprietary",
"type": "kirby-cms",
"version": "4.1.1",
"version": "4.1.2",
"keywords": [
"kirby",
"cms",
Expand Down
2 changes: 1 addition & 1 deletion composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion config/helpers.php
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ function deprecated(string $message): bool
}
}

if (Helpers::hasOverride('dump') === false) { // @codeCoverageIgnore
if (Helpers::hasOverride('dump') === false && function_exists('dump') === false) { // @codeCoverageIgnore
/**
* Simple object and variable dumper
* to help with debugging.
Expand Down
7 changes: 3 additions & 4 deletions config/methods.php
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@
$files = new Files([]);

foreach ($field->toData($separator) as $id) {
if ($file = $parent->kirby()->file($id, $parent)) {
if (is_string($id) === true && $file = $parent->kirby()->file($id, $parent)) {
$files->add($file);
}
}
Expand Down Expand Up @@ -481,10 +481,9 @@

foreach ($elements as $element) {
foreach ($attributes as $attribute) {
if ($element->hasAttribute($attribute) && $url = $element->getAttribute($attribute)) {
if ($element->hasAttribute($attribute) && $uuid = $element->getAttribute($attribute)) {
try {
if ($uuid = Uuid::for($url)) {
$url = $uuid->model()?->url();
if ($url = Uuid::for($uuid)?->model()?->url()) {
$element->setAttribute($attribute, $url);
}
} catch (InvalidArgumentException) {
Expand Down
2 changes: 1 addition & 1 deletion panel/dist/css/style.min.css

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion panel/dist/js/index.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion panel/dist/ui/Bubbles.json
Original file line number Diff line number Diff line change
@@ -1 +1 @@
{"description":"Display a list of <k-bubble>","tags":{"since":[{"description":"3.7.0","title":"since"}],"examples":[{"title":"example","content":"<k-bubbles :bubbles=\"['Hello', 'World']\" />"}]},"displayName":"Bubbles","props":[{"name":"html","description":"If set to `true`, the `text` is rendered as HTML code,\notherwise as plain text","type":{"name":"boolean"}},{"name":"bubbles","description":"Array or string of bubbles, see <k-bubble> for available props. If string, will be split by comma.","type":{"name":"array|string"}}],"component":"k-bubbles","sourceFile":"src/components/Layout/Bubbles.vue"}
{"description":"Display a list of `<k-bubble>`","tags":{"since":[{"description":"3.7.0","title":"since"}],"examples":[{"title":"example","content":"<k-bubbles :bubbles=\"['Hello', 'World']\" />"}]},"displayName":"Bubbles","props":[{"name":"html","description":"If set to `true`, the `text` is rendered as HTML code,\notherwise as plain text","type":{"name":"boolean"}},{"name":"bubbles","description":"Array or string of bubbles, see `<k-bubble>` for available props. If string, will be split by comma.","type":{"name":"array|string"}}],"component":"k-bubbles","sourceFile":"src/components/Layout/Bubbles.vue"}
12 changes: 6 additions & 6 deletions panel/src/components/Dialogs/LicenseDialog.vue
Original file line number Diff line number Diff line change
Expand Up @@ -16,18 +16,18 @@
<table style="table-layout: auto">
<tbody>
<tr>
<th>{{ $t("type") }}</th>
<td>{{ license.type }}</td>
<th data-mobile="true">{{ $t("type") }}</th>
<td data-mobile="true">{{ license.type }}</td>
</tr>
<tr v-if="license.code">
<th>{{ $t("license.code") }}</th>
<td class="k-text">
<th data-mobile="true">{{ $t("license.code") }}</th>
<td data-mobile="true" class="k-text">
<code>{{ license.code }}</code>
</td>
</tr>
<tr v-if="license.info">
<th>{{ $t("status") }}</th>
<td :data-theme="license.theme">
<th data-mobile="true">{{ $t("status") }}</th>
<td data-mobile="true" :data-theme="license.theme">
<p class="k-license-dialog-status">
<k-icon :type="license.icon" />
{{ license.info }}
Expand Down
10 changes: 10 additions & 0 deletions panel/src/components/Forms/Field/ObjectField.vue
Original file line number Diff line number Diff line change
Expand Up @@ -175,4 +175,14 @@ export default {
.k-table.k-object-field-table tbody td {
max-width: 0;
}
@container (max-width: 40rem) {
.k-object-field {
overflow: hidden;
}
.k-object-field-table.k-table tbody :where(th):is([data-mobile="true"]) {
width: 1px !important;
white-space: normal;
word-break: normal;
}
}
</style>
11 changes: 7 additions & 4 deletions panel/src/components/Forms/Toolbar/TextareaToolbar.vue
Original file line number Diff line number Diff line change
Expand Up @@ -153,10 +153,13 @@ export default {
if (button === "|") {
layout.push("|");
} else if (available[button]) {
// ensure that click handler is bound to this component
// so that plugins can use `this.command` etc.
const command = available[button];
command.click = command.click?.bind(this);
const command = {
...available[button],
click: () => {
available[button].click?.call(this);
}
};

layout.push(command);
}
}
Expand Down
4 changes: 2 additions & 2 deletions panel/src/components/Layout/Bubbles.vue
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ export const props = {
};

/**
* Display a list of <k-bubble>
* Display a list of `<k-bubble>`
* @since 3.7.0
*
* @example <k-bubbles :bubbles="['Hello', 'World']" />
Expand All @@ -30,7 +30,7 @@ export default {
inheritAttrs: false,
props: {
/**
* Array or string of bubbles, see <k-bubble> for available props. If string, will be split by comma.
* Array or string of bubbles, see `<k-bubble>` for available props. If string, will be split by comma.
*/
bubbles: [Array, String]
},
Expand Down
6 changes: 6 additions & 0 deletions panel/src/components/Layout/Frame/IconFrame.vue
Original file line number Diff line number Diff line change
Expand Up @@ -35,3 +35,9 @@ export default {
inheritAttrs: false
};
</script>

<style>
.k-icon-frame [data-type="emoji"] {
overflow: visible;
}
</style>
2 changes: 1 addition & 1 deletion panel/src/components/Layout/Table.vue
Original file line number Diff line number Diff line change
Expand Up @@ -530,7 +530,7 @@ export default {
/* Mobile */
@container (max-width: 40rem) {
.k-table {
overflow-x: scroll;
overflow-x: auto;
}
.k-table thead th {
position: static;
Expand Down
4 changes: 3 additions & 1 deletion src/Http/Remote.php
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,9 @@ public function __construct(string $url, array $options = [])
// use the system CA store by default if
// one has been configured in php.ini
$cainfo = ini_get('curl.cainfo');
if (empty($cainfo) === false && is_file($cainfo) === true) {

// Suppress warnings e.g. if system CA is outside of open_basedir (See: issue #6236)
if (empty($cainfo) === false && @is_file($cainfo) === true) {
$defaults['ca'] = self::CA_SYSTEM;
}

Expand Down
14 changes: 14 additions & 0 deletions tests/Content/FieldMethodsTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -429,6 +429,20 @@ public function testPermalinksToUrls()
$this->assertSame('<p>This is a <a href="/a">test</a><img src="/media/pages/a/' . $hash . '/test.jpg"></p>. This should not be <a href="https://getkirby.com">affected</a>.', (string)$result);
}

public function testPermalinksToUrlsWithMissingUUID()
{
$app = new App([
'roots' => [
'index' => static::TMP
],
]);

$field = $this->field('<p>This is a <a href="/@/page/my-page">test</a></p>.');
$result = $field->permalinksToUrls();

$this->assertSame('<p>This is a <a href="/@/page/my-page">test</a></p>.', (string)$result);
}

public function testToStructure()
{
$data = [
Expand Down
8 changes: 4 additions & 4 deletions vendor/composer/installed.php
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<?php return array(
'root' => array(
'name' => 'getkirby/cms',
'pretty_version' => '4.1.1',
'version' => '4.1.1.0',
'pretty_version' => '4.1.2',
'version' => '4.1.2.0',
'reference' => null,
'type' => 'kirby-cms',
'install_path' => __DIR__ . '/../../',
Expand Down Expand Up @@ -47,8 +47,8 @@
'dev_requirement' => false,
),
'getkirby/cms' => array(
'pretty_version' => '4.1.1',
'version' => '4.1.1.0',
'pretty_version' => '4.1.2',
'version' => '4.1.2.0',
'reference' => null,
'type' => 'kirby-cms',
'install_path' => __DIR__ . '/../../',
Expand Down
Loading