Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon for k-stat #5908

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Icon for k-stat #5908

merged 2 commits into from
Nov 3, 2023

Conversation

distantnative
Copy link
Member

This PR …

Enhancement

  • k-stat supports new icon prop

Used in System view:
Screenshot 2023-11-02 at 22 46 46

@distantnative distantnative added this to the 4.0-rc.1 milestone Nov 2, 2023
@distantnative distantnative requested a review from a team November 2, 2023 21:49
@distantnative distantnative self-assigned this Nov 2, 2023
@distantnative distantnative force-pushed the v4/enhancement/stat-icon branch 2 times, most recently from a8f7465 to 74bb147 Compare November 2, 2023 21:51
@distantnative distantnative force-pushed the v4/enhancement/stat-icon branch from 74bb147 to 6451075 Compare November 2, 2023 22:43
@bastianallgeier
Copy link
Member

TBH, the icons don't work for me on a non-retina screen in this size. They are barely recognizable

@distantnative
Copy link
Member Author

That's only because you have so giant screens 🤡

I think --text-md doesn't go well with the label font size anymore, but --text-sm works for me
Screenshot 2023-11-03 at 16 04 02
Screenshot 2023-11-03 at 16 04 40

afbora
afbora approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@afbora afbora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@afbora afbora requested a review from a team November 3, 2023 16:03
@distantnative distantnative merged commit ea9535f into v4/develop Nov 3, 2023
7 checks passed
@distantnative distantnative deleted the v4/enhancement/stat-icon branch November 3, 2023 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afbora afbora afbora approved these changes

Assignees

@distantnative distantnative

Labels
None yet
Milestone
4.0.0-rc.1
Development

Successfully merging this pull request may close these issues.
3 participants
@distantnative @bastianallgeier @afbora