Language label for the language switcher dropdown #5770
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
distantnative
force-pushed
the
v4/enhancement/language-label
branch
from
4ba7368 to
23dc168
Compare
lukasbestle
changed the title
lukasbestle
reviewed
Oct 9, 2023
|
What do you think about also new optional
|
bastianallgeier
force-pushed
the
v4/enhancement/language-label
branch
from
23dc168 to
d2da817
Compare
distantnative
force-pushed
the
v4/enhancement/language-label
branch
from
d2da817 to
c8a0950
Compare
|
Added 
|
distantnative
force-pushed
the
v4/enhancement/language-label
branch
from
947a1aa to
1ac3ca0
Compare
lukasbestle
reviewed
Oct 21, 2023
There was a problem hiding this comment.
If the label is left blank, the fallback to the code does not work.
Two possible solutions I can think of:
- Change
Language::update()to replace an empty string for the label withnull. This way, a dev could still manually set an empty string in the language file. But if changed via the UI, leaving the field blank will make it fall back to the code. - In the frontend, use a similar logic like with the code and locale fields (when changing the name or code fields, automatically update the label fields with the uppercase code). This one would probably be the most flexible as then the label could also be manually set to an empty string from the UI.
afbora
reviewed
Oct 22, 2023
| @@ -59,6 +60,7 @@ public function __construct(array $props) | |||
| $this->code = trim($props['code']); | |||
| $this->default = ($props['default'] ?? false) === true; | |||
| $this->direction = ($props['direction'] ?? null) === 'rtl' ? 'rtl' : 'ltr'; | |||
| $this->label = trim($props['label'] ?? Str::upper($this->code)); | |||
There was a problem hiding this comment.
This line is not working correctly. The label prop from the frontend is always sent as empty string. So if user doesn't enter label, language dropdown shows empty string.
Should be empty check for $props['label'] instead null check or label argument should be sent as null if not entered.
There was a problem hiding this comment.
Yep, also ran into that. See the possible solutions in the comment above.
distantnative
force-pushed
the
v4/enhancement/language-label
branch
from
e1bb84e to
45c3e8c
Compare
distantnative
added
the
needs: changes 🔁
|
Closing this for now until it's ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR …
Enhancement
labelof the Panel's languages dropdown for the currently selected language