No longer cache the license object

getkirby · Dec 4, 2024 · bb7c529 · bb7c529
1 parent 7e57f56
commit bb7c529
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 7 deletions.
diff --git a/src/Plugin/Plugin.php b/src/Plugin/Plugin.php
@@ -174,12 +174,8 @@ public function link(): string|null
 	 */
 	public function license(): License
 	{
-		if ($this->license instanceof License) {
-			return $this->license;
-		}
-
 		// resolve license info from Closure, array or string
-		return $this->license = License::from(
+		return License::from(
 			plugin: $this,
 			license: $this->license
 		);

diff --git a/tests/Plugin/PluginTest.php b/tests/Plugin/PluginTest.php
@@ -254,8 +254,6 @@ public function testLicense(): void
 	{
 		$plugin = new Plugin(name: 'getkirby/test-plugin');
 		$this->assertInstanceOf(License::class, $license = $plugin->license());
-		// check for cached instance
-		$this->assertSame($license, $plugin->license());
 	}
 
 	public function testLicenseFromString(): void