No longer send the checkbox event

getkirby · Dec 13, 2024 · a05c26d · a05c26d
1 parent a1a9a8f
commit a05c26d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/panel/src/components/Collection/Items.vue b/panel/src/components/Collection/Items.vue
@@ -48,7 +48,7 @@
 					@drag="onDragStart($event, item.dragText)"
 					@mouseover.native="$emit('hover', $event, item, itemIndex)"
 					@option="onOption($event, item, itemIndex)"
-					@select="onSelect($event, item, itemIndex)"
+					@select="onSelect(item, itemIndex)"
 				>
 					<template #options>
 						<slot name="options" v-bind="{ item, index: itemIndex }" />

diff --git a/panel/src/components/Layout/Table.vue b/panel/src/components/Layout/Table.vue
@@ -85,7 +85,7 @@
 								<label class="k-table-index-checkbox">
 									<input
 										type="checkbox"
-										@change="$emit('select', $event, row, rowIndex)"
+										@change="$emit('select', row, rowIndex)"
 									/>
 								</label>
 							</template>

diff --git a/panel/src/components/Sections/ModelsSection.vue b/panel/src/components/Sections/ModelsSection.vue
@@ -309,13 +309,13 @@ export default {
 			this.searching = !this.searching;
 			this.searchterm = null;
 		},
-		onSelect(event, item) {
-			if (event.target.checked) {
-				this.selected.push(item);
-			} else {
+		onSelect(item) {
+			if (this.selected.includes(item)) {
 				this.selected = this.selected.filter(
 					(selected) => selected.id !== item.id
 				);
+			} else {
+				this.selected.push(item);
 			}
 		},
 		onSelectToggle() {