Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Symfony YAML handler #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use Symfony YAML handler #66

wants to merge 1 commit into from

Conversation

distantnative
Copy link
Member

Description

Summary of changes

  • Switches to Symphony YAML handler

Reasoning

Before we switch the default in the Core, it would be good to run our kits first with this handler. Gives us more chances to catch any issues/differences that the new handler has, which would then allow us to make the default switch easier for developers.

@distantnative distantnative self-assigned this Sep 1, 2024
bastianallgeier
bastianallgeier approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@bastianallgeier bastianallgeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the panel views here as well and it all seems to be working just fine, which is great. I think we can just merge this one without adding an additional inline-comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bastianallgeier bastianallgeier bastianallgeier approved these changes

@lukasbestle lukasbestle Awaiting requested review from lukasbestle

Assignees

@distantnative distantnative

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@distantnative @bastianallgeier