Revert "fix whitespace encoding in urls" #3764
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3719
The code change from #3719 introduces a breaking change (as in, literally breaking) and throws a fatal error.
Culprit code:
This lacks sanity checks around the src presence under attributes, which throws a fatal error
Undefined array key "src"
./cc @dirkjf - Please recreate the PR with adequate checks and unit testing so we don't run into this again, thanks!