Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix whitespace encoding in urls" #3764

Merged
merged 2 commits into from
Oct 28, 2023
Merged

Revert "fix whitespace encoding in urls" #3764

merged 2 commits into from
Oct 28, 2023

Conversation

w00fz
Copy link
Member

@w00fz w00fz commented Oct 28, 2023

Reverts #3719

The code change from #3719 introduces a breaking change (as in, literally breaking) and throws a fatal error.

Culprit code:

$excerpt['element']['attributes']['src'] = str_replace(' ', '%20', $excerpt['element']['attributes']['src']);

This lacks sanity checks around the src presence under attributes, which throws a fatal error Undefined array key "src".

/cc @dirkjf - Please recreate the PR with adequate checks and unit testing so we don't run into this again, thanks!

@w00fz w00fz added the bug label Oct 28, 2023
@w00fz w00fz merged commit 0c9333e into develop Oct 28, 2023
5 checks passed
@w00fz w00fz self-assigned this Oct 28, 2023
@rhukster rhukster deleted the revert-3719-develop branch October 23, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant