prevent blog from breaking if specified hero_image is missing. Fixes Issue #87 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem is that if there is no image set, it still tries to render it. It's possible, even common where no image is set because it's not intended to have one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Issue #87
Previously, a missing hero_image caused a blog to crash horribly, exposing username and path names of a production server, and causing the website to be nonfunctional. The error is:
This PR fixes the problem and allows the vendor/GregWar module to generate a fallback.jpg image in path
images/f/a/l/l/bIn no case does the site crash, and as long as the user places an actual image in that path, the blog list does not display an error, but the fallback.jpg image.