Fix some accessibility issues #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix footer p - add HTML5 structure and ARIA landmarks
After #4f990f1, fix margin of p elements.
enhance screenreader experience with VoiceOver
maj theme
- add an aria-label for the button - add aria-expanded
rhukster
requested changes
Jul 25, 2018
|
I'm not proficient enough to do that unfortunately. I used the custom css because it was easier for me. I don't now how to use SCSS :/ |
NicoHood
reviewed
Oct 24, 2020
|
|
||
| <nav class="dropmenu animated"> | ||
| <div id="header" class="section"> | ||
| <div class="container {{ grid_size }}"> |
There was a problem hiding this comment.
Why did you remove the sections and renamed those to div? Does it has a specific reason?
NicoHood
reviewed
Oct 24, 2020
| <div class="container {{ grid_size }}"> | ||
| <div class="navbar"> | ||
| <header class="navbar-section logo" role="banner"> | ||
| <h1 class="navbar-section logo"><a href="{{ home_url }}" class="navbar-brand mr-10">{% include('@images/grav-logo.svg') %}</a></h1> |
There was a problem hiding this comment.
I do not recommend to use h1 here, as this completely breaks search engine optimization (seo).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.