-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update line-awesome to 1.3.0 (fixes #151) #152
base: develop
Are you sure you want to change the base?
Conversation
How did you recompile the line awesome source? To me it looks like you need to change some variables in the scss to make it work. Also I am wondering why |
Right, the I didn't recompile the line-awesome source. Just embedded the source from the link. |
I see but the link you provided has 1.2.0 icons, not 1.3.0 |
Yeah, I most likely used the download from their website: https://maxst.icons8.com/vue-static/landings/line-awesome/line-awesome/1.3.0/line-awesome-1.3.0.zip To be sure, someone should check hashes. However, I would be surprised if I hadn't used 1.3.0 and still wrote so in the PR. |
I tried it again, and it is really confusing to me. Details here: |
So I managed to update the font properly. There was a lot of files and information missing front line-awesome. I hope they will fix that. I managed to get support for almost every usecase now: icons8/line-awesome#33 (comment) |
I hope the getgrav team will merge this PR and make a new release soon - icons are a big part of the features module. |
Had to recompile scss, hence the changes.