Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update line-awesome to 1.3.0 (fixes #151) #152

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

sal0max
Copy link

@sal0max sal0max commented Jul 13, 2020

Had to recompile scss, hence the changes.

@NicoHood
Copy link
Contributor

NicoHood commented Oct 7, 2020

How did you recompile the line awesome source? To me it looks like you need to change some variables in the scss to make it work. Also I am wondering why fa is still working, shouldnt it be fas now?

@sal0max
Copy link
Author

sal0max commented Oct 7, 2020

Right, the fa prefix has been deprecated in font-awesome in version 5. The new default is the fas solid style and the fab style for brands. However I included line-awesome, not font-awesome, just like it was before. Just udpated the version.
line-awesome uses the la prefix, however alternatively supports also the fa prefix for compatibility reasons: https://github.com/icons8/line-awesome/tree/master/dist/font-awesome-line-awesome

I didn't recompile the line-awesome source. Just embedded the source from the link.
I had to recompile the quark scss, because the line-awesome.min.css changed.

@NicoHood
Copy link
Contributor

I see but the link you provided has 1.2.0 icons, not 1.3.0

@sal0max
Copy link
Author

sal0max commented Oct 12, 2020

Yeah, I most likely used the download from their website: https://maxst.icons8.com/vue-static/landings/line-awesome/line-awesome/1.3.0/line-awesome-1.3.0.zip
Can't say for sure, as this PR happened months ago...

To be sure, someone should check hashes. However, I would be surprised if I hadn't used 1.3.0 and still wrote so in the PR.

@NicoHood
Copy link
Contributor

I tried it again, and it is really confusing to me. Details here:
icons8/line-awesome#33 (comment)

@NicoHood
Copy link
Contributor

So I managed to update the font properly. There was a lot of files and information missing front line-awesome. I hope they will fix that. I managed to get support for almost every usecase now: fa, fas, las. So it should be almost safe to upgrade, even without modifying the theme icons or an of the plugins, that use the theme icons.

icons8/line-awesome#33 (comment)
https://github.com/NicoHood/grav-theme-quark/tree/magerquark

@o-pteron
Copy link

I hope the getgrav team will merge this PR and make a new release soon - icons are a big part of the features module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants