Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nice file attachment template listing #516

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

NicoHood
Copy link
Contributor

@NicoHood NicoHood commented Apr 2, 2021

With this change the template will list the uploaded files with a clickable link and the file size in brackets. Works with single and multi file upload.

@stephan-strate
Copy link
Contributor

I like the idea of having a clean output of the file instead of raw filepath, filename, size and mime.
But at least for me, the uploaded files are not reachable by url. Depending on the form submitted this would also be a huge privacy issue. Maybe we can add some configuration for this (eg. link: true|false).

@NicoHood
Copy link
Contributor Author

NicoHood commented Apr 7, 2021

Well the previous solution was not more privacy friendly anyways. So it is just a visual improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants