Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Checkboxes fix #472

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Checkboxes fix #472

wants to merge 2 commits into from

Conversation

NicoHood
Copy link
Contributor

@NicoHood NicoHood commented Jan 9, 2021

@NicoHood NicoHood mentioned this pull request Jan 9, 2021
Open
@NicoHood NicoHood mentioned this pull request Jan 9, 2021
Open
mahagr referenced this pull request Jan 11, 2021
@mahagr
Fixed state of the checkbox if no value is provided
bff6b9d
@NicoHood
Copy link
Contributor Author

NicoHood commented Feb 1, 2021

Would you mind merging this?

@rhukster
Copy link
Member

rhukster commented Feb 1, 2021

I will look at this one again now I've released Form.

@NicoHood
Copy link
Contributor Author

I have rebased my changes, simply removing the translation fix, as it was merged in #494

@mahagr
Copy link
Member

mahagr commented Feb 11, 2021

I won't accept this fix as it won't work in admin (it doesn't use form plugin, just the field), but I have an idea how to fix this.

mahagr
mahagr requested changes Feb 11, 2021
View reviewed changes
Copy link
Member

@mahagr mahagr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try another approach.

@NicoHood
Copy link
Contributor Author

Any progress on this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhukster rhukster rhukster left review comments

@mahagr mahagr mahagr requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple issues with checkboxes
3 participants
@NicoHood @rhukster @mahagr