Fix checkbox label margin (remove empty label) #442
Conversation
|
@rhukster Hey Andy, you have recently fixed some of the form template bugs, would you mind also having a look at this one? The linked issue has more details. |
| {% extends "forms/field.html.twig" %} | ||
|
|
||
| {% block label %} | ||
| {% endblock %} | ||
|
|
There was a problem hiding this comment.
I would approve this if you didn't remove the label block. It does no harm if not used, and might be being used by users with an extend
There was a problem hiding this comment.
@rhukster I am not sure if that would make sense. Since we are disabling the whole block, it cannot be displayed anyways. So even when extending the block (for whatever reason) it wont be displayed. Correct me, if I am wrong.
There was a problem hiding this comment.
I need more time to review this, but need to get a release out.. so will leave this one here until I can check it with the other label related PR
fix #441