Skip to content

Commit

Permalink
Concept hooks return status response in invokeServiceFor
Browse files Browse the repository at this point in the history
  • Loading branch information
PiotrNestor committed Feb 21, 2024
1 parent 394bd6c commit d5e502d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions runner/grpcRunner.go
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,11 @@ func (r *GrpcRunner) invokeServiceFor(message *gm.Message) (*gm.Message, error)
_, _ = r.RunnerClient.Kill(context.Background(), message.KillProcessRequest)
return nil, nil
case gm.Message_ConceptExecutionStarting:
_, err := r.RunnerClient.NotifyConceptExecutionStarting(context.Background(), message.ConceptExecutionStartingRequest)
return nil, err
response, err := r.RunnerClient.NotifyConceptExecutionStarting(context.Background(), message.ConceptExecutionStartingRequest)
return &gm.Message{MessageType: gm.Message_ExecutionStatusResponse, ExecutionStatusResponse: response}, err

Check failure on line 155 in runner/grpcRunner.go

View workflow job for this annotation

GitHub Actions / UTs ubuntu-latest

cannot use response (variable of type *gauge_messages.Empty) as *gauge_messages.ExecutionStatusResponse value in struct literal
case gm.Message_ConceptExecutionEnding:
_, err := r.RunnerClient.NotifyConceptExecutionEnding(context.Background(), message.ConceptExecutionEndingRequest)
return nil, err
response, err := r.RunnerClient.NotifyConceptExecutionEnding(context.Background(), message.ConceptExecutionEndingRequest)
return &gm.Message{MessageType: gm.Message_ExecutionStatusResponse, ExecutionStatusResponse: response}, err

Check failure on line 158 in runner/grpcRunner.go

View workflow job for this annotation

GitHub Actions / UTs ubuntu-latest

cannot use response (variable of type *gauge_messages.Empty) as *gauge_messages.ExecutionStatusResponse value in struct literal
default:
return nil, nil
}
Expand Down

0 comments on commit d5e502d

Please sign in to comment.