feat: add ditto operator support #19
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Merge contigent upon:
|
sl1pm4t
requested changes
Jan 15, 2025
| {{- /* Generate big peer deployment config driven by ditto operator */ -}} | ||
| {{- $fullname := include "common.names.fullname" . -}} | ||
| {{- $values := index .Values "ditto-deployment" -}} | ||
| {{- $storageClassName := default "local-path" $values.storage.storage_class_name -}} |
There was a problem hiding this comment.
StorageClass should be left blank by default, so that the cluster default is used.
local-path will not be compatible with most clusters.
| imagePullPolicy: {{ $values.image.pullPolicy }} | ||
| imagePullSecrets: [] | ||
| resources: | ||
| limits: |
There was a problem hiding this comment.
Could we expose these resource settings as values instead of hardcoding.
| imagePullSecrets: [] | ||
| resources: | ||
| limits: | ||
| cpu: 2000m |
| # Additional ingresses can be added by adding a dictionary key similar to the 'main' ingress. | ||
| # @default -- See below | ||
| ingress: | ||
| main: |
There was a problem hiding this comment.
Why is this being removed? Is this incompatible with Ditto Operator?
We are relying on this for valet.
charts/big-peer/Chart.lock
Outdated
| - name: hydra-consul | ||
| repository: oci://quay.io/ditto-external | ||
| - name: ditto-operator | ||
| repository: file://../../../ditto/charts/operator |
There was a problem hiding this comment.
We should update this to a public source.
charts/big-peer/Chart.yaml
Outdated
| repository: "oci://quay.io/ditto-external" | ||
| condition: hydra-subscription.enabled | ||
| #repository: "oci://quay.io/ditto-external" | ||
| repository: "file://../../../ditto/charts/operator" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for ditto operator, moving away from
hadesas we look towards its deprecation