Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: handle sub sat amounts #3265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions src/app/screens/ConfirmPayment/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,13 @@ function ConfirmPayment() {
const [fiatAmount, setFiatAmount] = useState("");
const [fiatBudgetAmount, setFiatBudgetAmount] = useState("");

const formattedInvoiceSats = getFormattedSats(invoice.satoshis || 0);
const formattedInvoiceSats = getFormattedSats(
invoice.satoshis
? invoice.satoshis
: invoice.millisatoshis
? Math.floor(parseInt(invoice.millisatoshis) / 1000)
: 0
);

useEffect(() => {
(async () => {
Expand Down Expand Up @@ -150,7 +156,15 @@ function ConfirmPayment() {
<div className="my-4">
<div className="mb-4 p-4 shadow bg-white dark:bg-surface-02dp rounded-lg">
<PaymentSummary
amount={invoice.satoshis || "0"} // TODO: allow entering amount or do not allow zero-amount invoices
amount={
invoice.satoshis
? invoice.satoshis
: invoice.millisatoshis
? Math.floor(
parseInt(invoice.millisatoshis) / 1000
).toString()
: "0"
} // TODO: allow entering amount or do not allow zero-amount invoices
fiatAmount={fiatAmount}
description={invoice.tagsObject.description}
/>
Expand Down
Loading