Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change name to wallet from account #3073

Closed
wants to merge 6 commits into from

Conversation

amitamrutiya
Copy link
Contributor

Describe the changes you have made in this PR

In this pull request, I replaced the account name with wallet in the majority of places. However, in some instances where the term wallet might not be suitable based on context, I retained account name. Additionally, I updated some translation variable names to include wallet. Furthermore, I made changes to the account setting screen by adding descriptions and section names. I updated this screen based on design suggested in this figma file.
 

Link this PR to an issue [optional]

Fixes #2872

Type of change

  • Change account to wallet name
  • Add wallet description and general section in wallet settings
  • Change name to delete_edit_wallet from delete_edit_account
  • Change name to wallet_view from account_view translation variable name
  • Change name to confirm_add_wallet from confirm_add_account translation variable name

Screenshots of the changes [optional]

image

How has this been tested?

I ensured that all the test cases are functioning correctly. Additionally, I tested all the margins, padding, and spacing to ensure they align with the design specifications I received.

Checklist

  • Self-review of changed code
  • Manual testing
  • Added automated tests where applicable
  • Update Docs & Guides
  • For UI-related changes
  • Darkmode
  • Responsive layout

@amitamrutiya amitamrutiya marked this pull request as ready for review March 10, 2024 03:54
@reneaaron reneaaron added the after-next-release Waiting for the next release (e.g. translations) label Mar 13, 2024
@reneaaron reneaaron added next-release To be included in the next release and removed after-next-release Waiting for the next release (e.g. translations) labels Mar 25, 2024
@stackingsaunter
Copy link
Contributor

I think this was done with some other PR by @pavanjoshi914. Sorry it went unreviewed @amitamrutiya2210

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
next-release To be included in the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Swap "accounts" for "wallets" copy
3 participants