-
Notifications
You must be signed in to change notification settings - Fork 194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new ui for mnemonic onboarding #2991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When there is no key yet and I click on "Generate new Master Key" I don't see the 3 list items explaining the backup of the Master Key:
They are currently only being shown when visiting the backup page (after generating). I think it would be useful to add these 3 points there as well.
Most users probably will never visit the backup page (as they confirm the backup while generating the key). cc @stackingsaunter
src/app/components/mnemonic/MnemonicBackupDescription/index.tsx
Outdated
Show resolved
Hide resolved
@pavanjoshi914 here you have 2x illustrations in png and svg |
@reneaaron we still need the designs for generating the master key page. @stackingsaunter is working on it i think! |
you meant this right? (when user deletes their master key) User, when after deleting Master KeyThe generation itself would look the same (and could happen after users click Continue on explenation page?) I posted designs in the file as well Other screens: User with MKUser with MK, but imported Nostr wallet |
@reneaaron there is separate pr for default master key generation. with this user will only see back everytime and generate master key screen will be only seen when user delete existing key and want to generate new key. #2988 shall we keep generate screen same as backup screen @stackingsaunter ? we don't have desings for this screen yet |
In my opinion yes, what would you change? @pavanjoshi914 |
I though the goal was to autogenerate the key, does it make sense to make it separate from UI then? In this PR there's no autogeneration cc @reneaaron @pavanjoshi914 Some feedback:
In Figma I did it by defining the width of number in front of the field the same size, so for double digits, and centered the numbers:
Maybe for now you can just delete the emoji |
@stackingsaunter autogeneration is here #2988 there was separate issue so i created separate pr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Describe the changes you have made in this PR
ui improvements for mnemonic onboarding
Link this PR to an issue [optional]
Fixes #2932
Type of change
(Remove other not matching type)
feat
: New feature (non-breaking change which adds functionality)Checklist